Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-32218: Only keep the one-bit flag in Flag.__iter__#23368

Closed
hongweipeng wants to merge 4 commits into
python:masterpython/cpython:masterfrom
hongweipeng:one-bit-flagshongweipeng/cpython:one-bit-flagsCopy head branch name to clipboard
Closed

bpo-32218: Only keep the one-bit flag in Flag.__iter__#23368
hongweipeng wants to merge 4 commits into
python:masterpython/cpython:masterfrom
hongweipeng:one-bit-flagshongweipeng/cpython:one-bit-flagsCopy head branch name to clipboard

Conversation

@hongweipeng

@hongweipeng hongweipeng commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

Comment thread Lib/enum.py Outdated
@@ -0,0 +1,2 @@
Only keep the one-bit flag for :meth:`Flag.__iter__` in :mod:`enum`. Patch by

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more details -- this news entry is a bit vague currently.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and I think it should be

:meth:`enum.Flag.__iter__`

But no link will be generated in any case.

Comment thread Lib/enum.py Outdated
Comment thread Lib/enum.py Outdated
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 10, 2021
@ethanfurman

Copy link
Copy Markdown
Member

Weipeng Hong, thank you for the patch. Instead of using this patch, I redesigned much of how iteration works with Flag members.

I look forward to your future efforts.

@hongweipeng hongweipeng deleted the one-bit-flags branch December 5, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.