Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-41100: Stripping '-arch arm64' didn't work after all#23280

Merged
ned-deily merged 1 commit into
python:masterpython/cpython:masterfrom
ronaldoussoren:bpo-41100-fix-arm64-stripperronaldoussoren/cpython:bpo-41100-fix-arm64-stripperCopy head branch name to clipboard
Nov 22, 2020
Merged

bpo-41100: Stripping '-arch arm64' didn't work after all#23280
ned-deily merged 1 commit into
python:masterpython/cpython:masterfrom
ronaldoussoren:bpo-41100-fix-arm64-stripperronaldoussoren/cpython:bpo-41100-fix-arm64-stripperCopy head branch name to clipboard

Conversation

@ronaldoussoren

@ronaldoussoren ronaldoussoren commented Nov 14, 2020

Copy link
Copy Markdown
Contributor

A last minute change to #22855 tried to remove all instances of "-arch arm64" instead of just the first one. That resulted in breaking that code :-(. This PR traverses the list in reverse order to avoid looking at items beyond the end of the list.

https://bugs.python.org/issue41100

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm in principle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.