Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-37193: Revert "remove thread objects which finished process its request"#23107

Merged
pablogsal merged 1 commit into
masterpython/cpython:masterfrom
revert-13893-fix-issue-37193python/cpython:revert-13893-fix-issue-37193Copy head branch name to clipboard
Nov 2, 2020
Merged

bpo-37193: Revert "remove thread objects which finished process its request"#23107
pablogsal merged 1 commit into
masterpython/cpython:masterfrom
revert-13893-fix-issue-37193python/cpython:revert-13893-fix-issue-37193Copy head branch name to clipboard

Conversation

@jaraco

@jaraco jaraco commented Nov 2, 2020

Copy link
Copy Markdown
Member

Reverts #13893

According to buildbots, the change introduces a memory leak.

https://bugs.python.org/issue37193

Automerge-Triggered-By: GH:jaraco

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A revert for now is fine, until someone has time to investigate the issue. This PR should unblock the next Python 3.10 release (today or tomorrow?).

cc @pablogsal

@pablogsal pablogsal merged commit aca67da into master Nov 2, 2020
@pablogsal pablogsal deleted the revert-13893-fix-issue-37193 branch November 2, 2020 16:48
jaraco added a commit that referenced this pull request Nov 3, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.