Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-38250: minor Flag refactor#22734

Closed
belm0 wants to merge 2 commits into
python:masterpython/cpython:masterfrom
belm0:flag_small_refactorbelm0/cpython:flag_small_refactorCopy head branch name to clipboard
Closed

bpo-38250: minor Flag refactor#22734
belm0 wants to merge 2 commits into
python:masterpython/cpython:masterfrom
belm0:flag_small_refactorbelm0/cpython:flag_small_refactorCopy head branch name to clipboard

Conversation

@belm0

@belm0 belm0 commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

Extracted some minor refactoring from a larger work in progress:

  • clarify used return values of _decompose() calls
  • __invert__(): use in-place OR operator, remove unneeded cast

skip news

https://bugs.python.org/issue38250

@auvipy auvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont this need some test adjustment?

@belm0

belm0 commented Oct 17, 2020

Copy link
Copy Markdown
Contributor Author

dont this need some test adjustment?

no, since there is no change in functionality

@belm0 belm0 force-pushed the flag_small_refactor branch from d1a0c1c to b86aa8e Compare November 23, 2020 00:36
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 24, 2020
@ethanfurman

Copy link
Copy Markdown
Member

@belm0 this PR is no longer valid as Flag has been redesigned (using much, if not all, of your input). I would appreciate your feedback on GH-24215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.