Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-30523: regrtest: Add --list-cases option#2238

Merged
vstinner merged 3 commits into
python:masterpython/cpython:masterfrom
mlouielu:bpo-30523-add-list-casemlouielu/cpython:bpo-30523-add-list-caseCopy head branch name to clipboard
Jun 16, 2017
Merged

bpo-30523: regrtest: Add --list-cases option#2238
vstinner merged 3 commits into
python:masterpython/cpython:masterfrom
mlouielu:bpo-30523-add-list-casemlouielu/cpython:bpo-30523-add-list-caseCopy head branch name to clipboard

Conversation

@mlouielu

Copy link
Copy Markdown
Contributor

No description provided.

@mention-bot

Copy link
Copy Markdown

@mlouielu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @zooba and @abalkin to be potential reviewers.

* Add get_abs_module() function, use it in list_cases()
* list_cases() now logs skipped tests into stderr
Comment thread Lib/test/libregrtest/main.py Outdated
if isinstance(test, unittest.loader._FailedTest):
continue
elif isinstance(test, doctest.DocTestCase):
continue

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this if: doctest falls into the the unittest.TestCase case, and... it just works! I'm able to pass to output to -m test --matchfile=tests and only these doctest tests are executed!

Comment thread Lib/test/libregrtest/main.py Outdated
@@ -1,4 +1,5 @@
import datetime
import doctest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this import (see above).

@vstinner vstinner merged commit a49c935 into python:master Jun 16, 2017
vstinner added a commit that referenced this pull request Jun 16, 2017
* bpo-30523: regrtest: Add --list-cases option (#2238)
* bpo-30284: Fix regrtest for out of tree build (#1481)
* bpo-30540: regrtest: add --matchfile option (#1909)
* bpo-30258: regrtest: Fix run_tests_multiprocess() (#1479)
* bpo-30263: regrtest: log system load (#1452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.