Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[3.9] bpo-41631: Fix a compiler warning in pycore_pylifecycle.h#22331

Merged
pablogsal merged 1 commit into
python:3.9python/cpython:3.9from
pablogsal:warningpablogsal/cpython:warningCopy head branch name to clipboard
Sep 21, 2020
Merged

[3.9] bpo-41631: Fix a compiler warning in pycore_pylifecycle.h#22331
pablogsal merged 1 commit into
python:3.9python/cpython:3.9from
pablogsal:warningpablogsal/cpython:warningCopy head branch name to clipboard

Conversation

@pablogsal

@pablogsal pablogsal commented Sep 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue41631

This PR suppress this warning introduced in 55e0836:

./Include/internal/pycore_pylifecycle.h:85:24: warning: this function declaration is not 1 warning generated.
a prototype [-Wstrict-prototypes]
extern void _PyAST_Fini();
                       ^
                        void

@pablogsal pablogsal requested a review from ambv September 20, 2020 22:16
@pablogsal pablogsal self-assigned this Sep 20, 2020
@pablogsal pablogsal requested a review from vstinner September 20, 2020 22:17
@pablogsal

pablogsal commented Sep 21, 2020

Copy link
Copy Markdown
Member Author

CC: @ambv

vstinner
vstinner approved these changes Sep 21, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal: You can merge it, and then ask @ambv to include it in 3.9.0 final.

@pablogsal pablogsal merged commit 724df83 into python:3.9 Sep 21, 2020
@pablogsal pablogsal deleted the warning branch September 21, 2020 10:57
@ambv

ambv commented Oct 4, 2020

Copy link
Copy Markdown
Contributor

Done.

ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
@pablogsal @ambv
Fix a compiler warning in pycore_pylifecycle.h (pythonGH-22331)
d636089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@corona10 corona10 corona10 approved these changes

@ambv ambv Awaiting requested review from ambv

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @ambv @vstinner @corona10 @the-knights-who-say-ni @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.