Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-39651: Fix asyncio proactor _write_to_self()#22197

Merged
vstinner merged 1 commit into
python:masterpython/cpython:masterfrom
vstinner:asyncio_write_to_selfCopy head branch name to clipboard
Sep 12, 2020
Merged

bpo-39651: Fix asyncio proactor _write_to_self()#22197
vstinner merged 1 commit into
python:masterpython/cpython:masterfrom
vstinner:asyncio_write_to_selfCopy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Sep 11, 2020

Copy link
Copy Markdown
Member

Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.

https://bugs.python.org/issue39651

Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
@vstinner

Copy link
Copy Markdown
Member Author

@1st1 @asvetlov: Would you mind to review my change?

I didn't test my patch, I basically copied/pasted the code between SelectorEventLoop to ProactorEventLoop.

@1st1

1st1 commented Sep 11, 2020

Copy link
Copy Markdown
Member

looks ok to me

@vstinner vstinner merged commit 1b0f0e3 into python:master Sep 12, 2020
@vstinner vstinner deleted the asyncio_write_to_self branch September 12, 2020 06:50
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2020
Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
(cherry picked from commit 1b0f0e3)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-22215 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2020
Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
(cherry picked from commit 1b0f0e3)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-22216 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Sep 12, 2020
Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
(cherry picked from commit 1b0f0e3)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Sep 12, 2020
Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
(cherry picked from commit 1b0f0e3)

Co-authored-by: Victor Stinner <vstinner@python.org>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Fix a race condition in the call_soon_threadsafe() method of
asyncio.ProactorEventLoop: do nothing if the self-pipe socket has
been closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.