[3.8] bpo-39010: Improve test shutdown (GH-22066)#22083
Merged
1st1 merged 1 commit intoSep 3, 2020
python:3.8python/cpython:3.8from
miss-islington:backport-be435ae-3.8miss-islington/cpython:backport-be435ae-3.8Copy head branch name to clipboard
Merged
[3.8] bpo-39010: Improve test shutdown (GH-22066)#220831st1 merged 1 commit intopython:3.8python/cpython:3.8from miss-islington:backport-be435ae-3.8miss-islington/cpython:backport-be435ae-3.8Copy head branch name to clipboard
1st1 merged 1 commit into
python:3.8python/cpython:3.8from
miss-islington:backport-be435ae-3.8miss-islington/cpython:backport-be435ae-3.8Copy head branch name to clipboard
Conversation
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to pythonGH-22017 (cherry picked from commit be435ae) Co-authored-by: Ben Darnell <ben@bendarnell.com>
1st1
approved these changes
Sep 3, 2020
|
@1st1: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.
Follow-up to GH-22017
(cherry picked from commit be435ae)
Co-authored-by: Ben Darnell ben@bendarnell.com
https://bugs.python.org/issue39010
Automerge-Triggered-By: @1st1