bpo-41631: Check that importing _ast returns the right module #21973
Closed
encukou wants to merge 4 commits into
python:masterpython/cpython:masterfrom
encukou:check-ast-module-def_masterencukou/cpython:check-ast-module-def_masterCopy head branch name to clipboard
Closed
bpo-41631: Check that importing _ast returns the right module #21973encukou wants to merge 4 commits intopython:masterpython/cpython:masterfrom encukou:check-ast-module-def_masterencukou/cpython:check-ast-module-def_masterCopy head branch name to clipboard
encukou wants to merge 4 commits into
python:masterpython/cpython:masterfrom
encukou:check-ast-module-def_masterencukou/cpython:check-ast-module-def_masterCopy head branch name to clipboard
Conversation
Member
Author
|
@pablogsal, does this make sense for |
Member
Yup, it does sense to me as a temporary solution 👍 |
pablogsal
approved these changes
Sep 8, 2020
pablogsal
reviewed
Sep 8, 2020
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
The previous behavior didn't always segfault -- in fact, it usually raised a SystemError as well. A segfault (or any other behavior, depending on the module object imported as _ast) was still *possible*, but for that level of detail people should see the bpo issue.
Member
|
Thanks for the workaround. PR 21961 fix has been merged instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully #21961 will be OK, but if not: here is a relatively minimal fix for bpo-41631, which basically makes compiling to/from AST fail gracefully (with a proper exception rather than a NULL without exception) if the
_astmodule has been tampered with.For example, it looks like Mercurial's lazy-loading scheme replaces
_astwith a proxy object; this will make AST unusable.The second commit deals with a hack in pegen's tests – please review the commits separately, and see comments.
https://bugs.python.org/issue41631