[3.8] closes bpo-38156: Always handle interrupts in PyOS_StdioReadline. (GH-21569)#21671
Merged
miss-islington merged 1 commit intoJul 29, 2020
python:3.8python/cpython:3.8from
miss-islington:backport-a74eea2-3.8miss-islington/cpython:backport-a74eea2-3.8Copy head branch name to clipboard
Merged
[3.8] closes bpo-38156: Always handle interrupts in PyOS_StdioReadline. (GH-21569)#21671miss-islington merged 1 commit intopython:3.8python/cpython:3.8from miss-islington:backport-a74eea2-3.8miss-islington/cpython:backport-a74eea2-3.8Copy head branch name to clipboard
miss-islington merged 1 commit into
python:3.8python/cpython:3.8from
miss-islington:backport-a74eea2-3.8miss-islington/cpython:backport-a74eea2-3.8Copy head branch name to clipboard
Conversation
…thonGH-21569) This consolidates the handling of my_fgets return values, so that interrupts are always handled, even if they come after EOF. I believe PyOS_StdioReadline is still buggy in that I/O errors will not result in a proper Python exception being set. However, that is a separate issue. (cherry picked from commit a74eea2) Co-authored-by: Benjamin Peterson <benjamin@python.org>
benjaminp
approved these changes
Jul 29, 2020
Contributor
Author
|
@benjaminp: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consolidates the handling of my_fgets return values, so that interrupts are always handled, even if they come after EOF.
I believe PyOS_StdioReadline is still buggy in that I/O errors will not result in a proper Python exception being set. However, that is a separate issue.
(cherry picked from commit a74eea2)
Co-authored-by: Benjamin Peterson benjamin@python.org
https://bugs.python.org/issue38156