Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Optimized Images in repo#21348

Merged
methane merged 2 commits into
python:mainpython/cpython:mainfrom
manishprivet:mastermanishprivet/cpython:masterCopy head branch name to clipboard
Feb 4, 2022
Merged

Optimized Images in repo#21348
methane merged 2 commits into
python:mainpython/cpython:mainfrom
manishprivet:mastermanishprivet/cpython:masterCopy head branch name to clipboard

Conversation

@manishprivet

@manishprivet manishprivet commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

Optimized Images

Optimized .png and .svg images in repo by 11.69% using IMGBot.

ImgBotApp and others added 2 commits July 1, 2020 09:31
@ImgBotApp
[ImgBot] Optimize images
7e30c3a 
*Total -- 348.88kb -> 309.06kb (11.41%)

/PC/icons/py.png -- 13.82kb -> 8.33kb (39.69%)
/Lib/idlelib/Icons/idle_16.gif -- 1.01kb -> 0.62kb (38.68%)
/PC/icons/pythonwx150.png -- 8.00kb -> 4.97kb (37.89%)
/PC/icons/pythonx150.png -- 8.08kb -> 5.11kb (36.74%)
/Lib/idlelib/Icons/python.gif -- 0.57kb -> 0.37kb (35.04%)
/Lib/test/imghdrdata/python.gif -- 0.60kb -> 0.40kb (33.61%)
/Lib/idlelib/Icons/idle_32.gif -- 1.40kb -> 1.00kb (28.99%)
/Doc/library/tk_msg.png -- 19.18kb -> 14.63kb (23.75%)
/Lib/idlelib/Icons/minusnode.gif -- 0.09kb -> 0.07kb (21.88%)
/Lib/idlelib/Icons/idle_32.png -- 2.48kb -> 1.99kb (19.91%)
/Lib/idlelib/Icons/idle_16.png -- 1.23kb -> 1.01kb (18.43%)
/PC/icons/pythonx44.png -- 2.13kb -> 1.75kb (17.86%)
/PC/icons/pythonwx44.png -- 2.18kb -> 1.80kb (17.38%)
/Lib/idlelib/Icons/idle_48.png -- 4.60kb -> 3.88kb (15.56%)
/Lib/idlelib/Icons/tk.gif -- 0.08kb -> 0.07kb (15.29%)
/Doc/using/win_installer.png -- 92.87kb -> 82.41kb (11.27%)
/Tools/msi/bundle/SideBar.png -- 56.53kb -> 50.73kb (10.27%)
/Lib/idlelib/Icons/idle_256.png -- 41.83kb -> 38.29kb (8.48%)
/Lib/test/test_email/data/PyBanner048.gif -- 0.93kb -> 0.88kb (6.08%)
/PC/icons/pythonx50.png -- 2.14kb -> 2.10kb (1.64%)
/Lib/idlelib/Icons/plusnode.gif -- 0.08kb -> 0.08kb (1.27%)
/PC/icons/logox128.png -- 1.17kb -> 1.16kb (1.16%)
/Doc/howto/logging_flow.png -- 21.54kb -> 21.39kb (0.68%)
/Doc/library/hashlib-blake2-tree.png -- 10.88kb -> 10.81kb (0.68%)
/Doc/library/pathlib-inheritance.svg -- 55.44kb -> 55.23kb (0.39%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
@manishprivet
Merge pull request #1 from manishprivet/imgbot
572c960 
[ImgBot] Optimize images
@manishprivet manishprivet requested review from a team, terryjreedy, tiran and vsajip as code owners July 6, 2020 12:29
@the-knights-who-say-ni

the-knights-who-say-ni commented Jul 6, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@manishprivet, @ImgBotApp

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@manishprivet manishprivet reopened this Jul 6, 2020
@merwok

merwok commented Jul 6, 2020

Copy link
Copy Markdown
Member

@methane you ran optipng before, maybe you’re interested in reviewing this 🙂

@manishprivet manishprivet reopened this Jul 6, 2020
@methane

methane commented Jul 7, 2020

Copy link
Copy Markdown
Member

Thank you for proposing it. I have not known IMGbot.

Before merging this pull request, I made a suggestion about installing IMGBot app on this repository.
See https://discuss.python.org/t/optimize-images-by-imgbot/4672

@manishprivet

manishprivet commented Jul 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I guess there's some problem on the b.p.o site, as after registration, when I clicked on the link in confirmation email, it only showed
Invalid URL scheme in homepage URL,
and my email isn't registered yet.

bpo error

EDIT: I raised an issue here

@manishprivet manishprivet reopened this Jul 8, 2020
@csabella

csabella commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

@manishprivet, please sign the CLA. Thank you!

@manishprivet

manishprivet commented Sep 21, 2020

Copy link
Copy Markdown
Contributor Author

@manishprivet, please sign the CLA. Thank you!

Done. My B.P.O. username is user35899 and Login name is manishprivet1, but it's still showing CLA Not Signed here

@terryjreedy

terryjreedy commented Sep 21, 2020

Copy link
Copy Markdown
Member

When did you sign? (It can take up to a week to get recorded.) You are 'User35899', but your username is your login name, and I am pretty sure that the latter is what you need to put on the form.

Since you have never used the older 'manishprivet', it might be possible to delete it, except I don't know who to ask.

@manishprivet

manishprivet commented Sep 21, 2020

Copy link
Copy Markdown
Contributor Author

I signed it today itself.
image

hugovk
hugovk approved these changes Feb 3, 2022
View reviewed changes

@hugovk hugovk left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I visually inspected and the images are still the same.

@hugovk

hugovk commented Feb 3, 2022

Copy link
Copy Markdown
Member

Closing/re-opening to poke the CI.

@hugovk hugovk closed this Feb 3, 2022
@hugovk hugovk reopened this Feb 3, 2022
@hugovk

hugovk commented Feb 3, 2022

Copy link
Copy Markdown
Member

✅ CI now green.

If we don't want commits from @ImgBotApp (but https://discuss.python.org/t/optimize-images-by-imgbot/4672 would be nice, I use it on other repos), we can easily make a new PR after running something like:

find . -type f -iname "*.png" -exec optipng -o7 -zm1-9 {} \;

Saves about 17.5%.

@methane methane merged commit ba650af into python:main Feb 4, 2022
@miss-islington

miss-islington commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @manishprivet for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Feb 4, 2022

Copy link
Copy Markdown

GH-31123 is a backport of this pull request to the 3.9 branch.

@miss-islington

miss-islington commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @manishprivet for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @manishprivet for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2022
@manishprivet @miss-islington
Optimize images by IMGbot (pythonGH-21348)
b196487 
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
(cherry picked from commit ba650af)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2022
@manishprivet @miss-islington
Optimize images by IMGbot (pythonGH-21348)
6f1f480 
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
(cherry picked from commit ba650af)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 4, 2022
@bedevere-bot

bedevere-bot commented Feb 4, 2022

Copy link
Copy Markdown

GH-31124 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Feb 4, 2022
@miss-islington @manishprivet
Optimize images by IMGbot (GH-21348)
ee3d050 
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
(cherry picked from commit ba650af)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
methane pushed a commit that referenced this pull request Feb 4, 2022
@miss-islington @ImgBotApp
Optimize images by IMGbot (GH-21348)
34895f6 
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
(cherry picked from commit ba650af)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @manishprivet @hello-adam
Optimize images by IMGbot (pythonGH-21348)
24581be 
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
(cherry picked from commit ba650af)

Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.