bpo-41100: use system libffi for Mac OS 10.15 and up#21239
Closed
lawrence-danna-apple wants to merge 2 commits into
python:masterpython/cpython:masterfrom
lawrence-danna-apple:postback-0003lawrence-danna-apple/cpython:postback-0003Copy head branch name to clipboard
Closed
bpo-41100: use system libffi for Mac OS 10.15 and up#21239lawrence-danna-apple wants to merge 2 commits intopython:masterpython/cpython:masterfrom lawrence-danna-apple:postback-0003lawrence-danna-apple/cpython:postback-0003Copy head branch name to clipboard
lawrence-danna-apple wants to merge 2 commits into
python:masterpython/cpython:masterfrom
lawrence-danna-apple:postback-0003lawrence-danna-apple/cpython:postback-0003Copy head branch name to clipboard
Conversation
This updates setup.py to default to the system libffi on Mac OS 10.15 and forward. It also updates detect_ctypes to prefer finding libffi in the Xcode SDK, rather than /usr/include Also, when the Mac OS libffi is used, it removes malloc_closure.c from the sourcs for _ctypes. libffi already comes with ffi_closure_alloc, and it is not compatible with the one in malloc_closure.c
Contributor
|
Do you know how far back libffi is included with macOS and part of the SDK? |
Contributor
Author
Looks like it goes back to at least 10.11, but 10.15 is the first one that has |
Contributor
Author
|
superseded by #21249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored libffi sources do not support arm64 Mac OS. Recent versions of mac OS include libffi, including Mac OS 11 on arm64.
This updates setup.py to default to the system libffi on Mac OS 10.15 and forward. It also updates
detect_ctypes to prefer finding libffi in the Xcode SDK, rather than /usr/include
Also, when the Mac OS libffi is used, it removes malloc_closure.c from the sourcs for _ctypes.
libffi already comes with ffi_closure_alloc, and it is not compatible with the one in
malloc_closure.c
https://bugs.python.org/issue41100