bpo-38870: Extend subject of ast.unparse warnings#21053
Merged
pablogsal merged 1 commit intoJun 28, 2020
python:masterpython/cpython:masterfrom
isidentical:bpo-38870-doc-warnsisidentical/cpython:bpo-38870-doc-warnsCopy head branch name to clipboard
Merged
bpo-38870: Extend subject of ast.unparse warnings#21053pablogsal merged 1 commit intopython:masterpython/cpython:masterfrom isidentical:bpo-38870-doc-warnsisidentical/cpython:bpo-38870-doc-warnsCopy head branch name to clipboard
pablogsal merged 1 commit into
python:masterpython/cpython:masterfrom
isidentical:bpo-38870-doc-warnsisidentical/cpython:bpo-38870-doc-warnsCopy head branch name to clipboard
Conversation
- Mention that some compiler optimizations might not roundtrip exactly (such as constant tuples and frozensets). - Add a warning about it might raise RecursionError on very complex expressions due to recursive unparsing aspect of ast.unparse
pablogsal
approved these changes
Jun 28, 2020
Contributor
|
Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Sorry @isidentical and @pablogsal, I had trouble checking out the |
pablogsal
pushed a commit
to pablogsal/cpython
that referenced
this pull request
Jun 28, 2020
- Mention that some compiler optimizations might not roundtrip exactly (such as constant tuples and frozensets). - Add a warning about it might raise RecursionError on very complex expressions due to recursive unparsing aspect of ast.unparse (cherry picked from commit 8df1016) Co-authored-by: Batuhan Taskaya <batuhanosmantaskaya@gmail.com>
|
GH-21191 is a backport of this pull request to the 3.9 branch. |
fasih
pushed a commit
to fasih/cpython
that referenced
this pull request
Jun 29, 2020
- Mention that some compiler optimizations might not roundtrip exactly (such as constant tuples and frozensets). - Add a warning about it might raise RecursionError on very complex expressions due to recursive unparsing aspect of ast.unparse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mention that some compiler optimizations might not roundtrip
exactly (such as constant tuples and frozensets).
Add a warning about it might raise RecursionError on very
complex expressions due to recursive unparsing aspect of ast.unparse
https://bugs.python.org/issue38870