Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-35018: Sax parser provides no user access to lexical handlers#20958

Merged
scoder merged 6 commits into
python:masterpython/cpython:masterfrom
ZackerySpytz:bpo-35018-xml-LexicalHandlerZackerySpytz/cpython:bpo-35018-xml-LexicalHandlerCopy head branch name to clipboard
Aug 9, 2020
Merged

bpo-35018: Sax parser provides no user access to lexical handlers#20958
scoder merged 6 commits into
python:masterpython/cpython:masterfrom
ZackerySpytz:bpo-35018-xml-LexicalHandlerZackerySpytz/cpython:bpo-35018-xml-LexicalHandlerCopy head branch name to clipboard

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Jun 18, 2020

Copy link
Copy Markdown
Contributor

Co-Authored-By: Jonathan Gossage jgossage@gmail.com

https://bugs.python.org/issue35018

Co-Authored-By: Jonathan Gossage <jgossage@gmail.com>

@scoder scoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one issue regarding the usage documentation.

Comment thread Lib/xml/sax/handler.py Outdated
Comment thread Lib/xml/sax/handler.py Outdated
Comment thread Doc/library/xml.sax.handler.rst Outdated
@ZackerySpytz

Copy link
Copy Markdown
Contributor Author

Hi, @scoder. Can this PR be merged?

@ZackerySpytz

Copy link
Copy Markdown
Contributor Author

@scoder Ping?

@scoder scoder merged commit e28b8c9 into python:master Aug 9, 2020
@scoder

scoder commented Aug 9, 2020

Copy link
Copy Markdown
Contributor

Let's get this in. Thanks @jgossage and @ZackerySpytz for you contribution.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.