Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-40998: Address compiler warnings found by ubsan#20929

Merged
miss-islington merged 2 commits into
python:masterpython/cpython:masterfrom
tiran:bpo-40998-ubsan-warningstiran/cpython:bpo-40998-ubsan-warningsCopy head branch name to clipboard
Nov 18, 2020
Merged

bpo-40998: Address compiler warnings found by ubsan#20929
miss-islington merged 2 commits into
python:masterpython/cpython:masterfrom
tiran:bpo-40998-ubsan-warningstiran/cpython:bpo-40998-ubsan-warningsCopy head branch name to clipboard

Conversation

@tiran

@tiran tiran commented Jun 17, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue40998

Automerge-Triggered-By: GH:tiran

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Python/pylifecycle.c Outdated
@tiran

tiran commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

This PR also addresses a reference leak that was introduced in 86ea581 / GH-13159

Comment thread Python/_warnings.c Outdated
@tiran tiran force-pushed the bpo-40998-ubsan-warnings branch from de6090b to 851deb9 Compare November 18, 2020 14:57
@miss-islington

Copy link
Copy Markdown
Contributor

@tiran: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 07f2ade into python:master Nov 18, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 18, 2020
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran
(cherry picked from commit 07f2ade)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-23370 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 18, 2020
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran
(cherry picked from commit 07f2ade)

Co-authored-by: Christian Heimes <christian@python.org>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.