Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.8] bpo-34401: Fix test_gdb for HP GDB version string (GH-20804)#20806

Merged
miss-islington merged 1 commit into
python:3.8python/cpython:3.8from
miss-islington:backport-b2dca49-3.8miss-islington/cpython:backport-b2dca49-3.8Copy head branch name to clipboard
Jun 11, 2020
Merged

[3.8] bpo-34401: Fix test_gdb for HP GDB version string (GH-20804)#20806
miss-islington merged 1 commit into
python:3.8python/cpython:3.8from
miss-islington:backport-b2dca49-3.8miss-islington/cpython:backport-b2dca49-3.8Copy head branch name to clipboard

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 11, 2020

Copy link
Copy Markdown
Contributor

The GDB provided by HPE on HP-UX contains a modified version string. Therefore
the tests fail. Adapt the regex to match that string.

Patch by Michael Osipov.

Co-Authored-by: Michael Osipov michael.osipov@siemens.com
(cherry picked from commit b2dca49)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue34401

The GDB provided by HPE on HP-UX contains a modified version string. Therefore
the tests fail. Adapt the regex to match that string.

Patch by Michael Osipov.

Co-Authored-by: Michael Osipov <michael.osipov@siemens.com>
(cherry picked from commit b2dca49)

Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 5b8e3a5 into python:3.8 Jun 11, 2020
@miss-islington miss-islington deleted the backport-b2dca49-3.8 branch June 11, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.