Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-40509: Enable REMAINDER argparse arguments to be used in mutually exclusive …#19919

Closed
shaniarmon wants to merge 1 commit into
python:mainpython/cpython:mainfrom
shaniarmon:fix-issue-40509Copy head branch name to clipboard
Closed

bpo-40509: Enable REMAINDER argparse arguments to be used in mutually exclusive …#19919
shaniarmon wants to merge 1 commit into
python:mainpython/cpython:mainfrom
shaniarmon:fix-issue-40509Copy head branch name to clipboard

Conversation

@shaniarmon

@shaniarmon shaniarmon commented May 5, 2020

Copy link
Copy Markdown

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@shaniarmon

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@taleinat

Copy link
Copy Markdown
Contributor

Hi Shani, thanks for this PR!

Besides waiting for additional discussion of the issue itself, note that this PR will eventually also need to include an update for the argparse docs before it could be merged.

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could help to understand what this code do and whether it does it correctly if the PR included tests and docs.

@bedevere-app

bedevere-app Bot commented Feb 28, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@shaniarmon shaniarmon closed this by deleting the head repository Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.