Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-84404: Add -fwrapv for new icc versions#19561

Open
furkanonder wants to merge 3 commits into
python:mainpython/cpython:mainfrom
furkanonder:bpo-40223Copy head branch name to clipboard
Open

gh-84404: Add -fwrapv for new icc versions#19561
furkanonder wants to merge 3 commits into
python:mainpython/cpython:mainfrom
furkanonder:bpo-40223Copy head branch name to clipboard

Conversation

@furkanonder

@furkanonder furkanonder commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

@isidentical isidentical requested a review from skrah April 17, 2020 06:55
@csabella csabella requested review from skrah and removed request for skrah May 23, 2020 18:03
@furkanonder

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

: please review the changes made to this pull request.

@skrah

skrah commented Jun 30, 2020

Copy link
Copy Markdown
Contributor

We need to check first whether icc supports -fwrapv. Not all versions do that.

Then, for consistency, set the WRAP variable like for the other compilers based on the result of the check.

@skrah

skrah commented Jun 30, 2020

Copy link
Copy Markdown
Contributor

And add a news entry, because most people here like that.

@furkanonder

furkanonder commented Aug 25, 2020

Copy link
Copy Markdown
Contributor Author

Hi Stefan, I compiled successfully using icc 19.1.2 version. Now, the problem has been fixed. Can you review again?

@furkanonder furkanonder closed this by deleting the head repository Dec 23, 2022
@furkanonder furkanonder reopened this Dec 23, 2022
@furkanonder

Copy link
Copy Markdown
Contributor Author

@skrah Ping

@corona10 corona10 self-assigned this May 9, 2023
@furkanonder furkanonder added the build The build process and cross-build label Aug 6, 2023
@furkanonder furkanonder changed the title bpo-40223: Add -fwrapv for new icc versions gh-84404: Add -fwrapv for new icc versions Aug 6, 2023
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting change review build The build process and cross-build stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.