bpo-40176: Improve error messages for unclosed string literals#19346
bpo-40176: Improve error messages for unclosed string literals#19346
Conversation
|
This message is still a bit jargon-y, I think Rust's error message in this case is pretty nice: |
That definitely looks more simpler to those who unfamiliar with parser jargon. I'm not sure if we should still use EOF/EOL when needed or not though. |
c75e26e to
0b6386d
Compare
c7b3048 to
4c24faa
Compare
4c24faa to
fcecf4b
Compare
|
as a data point my (non-cs) students always get confused by the EOF and EOL abbreviation. PyPy's message is: |
|
we actually don't use EOF/EOL anymore, just "unterminated string literal" |
|
ah great (sorry, hadn't read the diff yet, just saw the earlier comment) |
pablogsal
left a comment
There was a problem hiding this comment.
LGTM
Feel free to land once you address the minor comment
|
@isidentical: Status check is done, and it's a success ✅ . |
…nGH-19346) Automerge-Triggered-By: GH:isidentical
https://bugs.python.org/issue40176
Automerge-Triggered-By: GH:isidentical