Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-37860: Enable docs deploy previews through GitHub Actions#19025

Closed
epicfaace wants to merge 21 commits into
python:mainpython/cpython:mainfrom
epicfaace:masterepicfaace/cpython:masterCopy head branch name to clipboard
Closed

bpo-37860: Enable docs deploy previews through GitHub Actions#19025
epicfaace wants to merge 21 commits into
python:mainpython/cpython:mainfrom
epicfaace:masterepicfaace/cpython:masterCopy head branch name to clipboard

Conversation

@epicfaace

@epicfaace epicfaace commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

@hugovk

hugovk commented Jan 12, 2022

Copy link
Copy Markdown
Member

This looks good, although one downside is it creates a new directory for each and every commit pushed to a PR:

That's going to get pretty big and fast, so would need to have some way to cleanup old ones.

It would be better to use the PR number instead of commit SHA and only build PRs that change docs or docs build logic.

Also I wonder if that amount of churn on a single branch would have a performance impact on the rest of the Git repo?

Perhaps another host server would be better.

@epicfaace

Copy link
Copy Markdown
Contributor Author
  • 586 MB for 10 builds

Yeah, and GitHub Pages also has a hard limit of 1 GB in size -- https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages#usage-limits. Why is the docs site so large again? Are there certain large static files that can be symlinked / shared between deploy previews?

It would be better to use the PR number instead of commit SHA and only build PRs that change docs or docs build logic.

Good idea.

Also I wonder if that amount of churn on a single branch would have a performance impact on the rest of the Git repo?

I don't think it will be an issue as long as we clean up merged PRs -- so we only include PRs in this branch that are currently open.

@epicfaace epicfaace mannequin mentioned this pull request Apr 16, 2022
@epicfaace

Copy link
Copy Markdown
Contributor Author

Closing in favor of #92852

@epicfaace epicfaace closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.