bpo-39683: 2to3 fix_exitfunc suggests duplicated import of atexit module#18654
Closed
phsilva wants to merge 1 commit into
Closed
bpo-39683: 2to3 fix_exitfunc suggests duplicated import of atexit module#18654phsilva wants to merge 1 commit into
phsilva wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18654 +/- ##
===========================================
+ Coverage 82.06% 83.13% +1.06%
===========================================
Files 1956 1571 -385
Lines 589514 414887 -174627
Branches 44464 44465 +1
===========================================
- Hits 483809 344928 -138881
+ Misses 96052 60339 -35713
+ Partials 9653 9620 -33
Continue to review full report at Codecov.
|
isidentical
reviewed
Mar 7, 2020
2to3 fix for sys.exitfunc adds multiple import when sys.exitfunc is present multiple times. This patch adds a check for already existing 'import atexit' and do not add multiple imports.
isidentical
approved these changes
Mar 17, 2020
Member
|
Closed under bpo-45544. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2to3 fix for sys.exitfunc adds multiple imports when sys.exitfunc
is present multiple times.
This patch adds a check for already existing 'import atexit' and
do not add multiple imports.
https://bugs.python.org/issue39683