gh-64490: varargs support for argument clinic and refactor print with AC#18609
Merged
Merged
gh-64490: varargs support for argument clinic and refactor print with AC#18609
Conversation
169a88a to
10a983e
Compare
8dca07a to
239ad97
Compare
0ae57a2 to
deef95c
Compare
Codecov Report
@@ Coverage Diff @@
## master #18609 +/- ##
===========================================
+ Coverage 82.08% 83.20% +1.12%
===========================================
Files 1956 1571 -385
Lines 589394 414936 -174458
Branches 44457 44482 +25
===========================================
- Hits 483778 345267 -138511
+ Misses 95969 60023 -35946
+ Partials 9647 9646 -1
Continue to review full report at Codecov.
|
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Interesting PR. Thank you that taken this issue Batuhan! 👍 But it will take a time to make a review.
a9ffdcb to
445eaa5
Compare
Member
|
@serhiy-storchaka Could you review this PR if you have the time? If you are busy I can finish the review myself and try to land it so it reaches 3.11 :) |
Member
|
@isidentical Can you rebase this and we can land it? |
|
🤖 New build scheduled with the buildbot fleet by @isidentical for commit 4186327 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
pablogsal
approved these changes
Jul 13, 2021
Member
|
@isidentical Land if the buildbots are happy. Don't forget to also change the docs for the argument clinic in the devguide with any updates! |
Member
|
The Doc/howto/clinic.rst docs still need updating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f(*args, /)f(x, y, *args, /)f(*args)f(x, y, *args)f(x, /, y, *args)f(x, *args, y=3)f(*args, y=3, z=5)https://bugs.python.org/issue20291