bpo-30499: Remove a deprecated note about sets.#1848
Merged
Merged
bpo-30499: Remove a deprecated note about sets.#1848
Conversation
|
@JulienPalard, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @ncoghlan and @benjaminp to be potential reviewers. |
rhettinger
reviewed
May 29, 2017
Contributor
There was a problem hiding this comment.
While correct, this leaves the mechanism as a mystery. There should probably be a sentence saying that a new temporary frozenset is built from elem. That would be a minor implementation detail except for the O(n) conversion cost.
rhettinger
requested changes
May 29, 2017
rhettinger
left a comment
Contributor
There was a problem hiding this comment.
Add a note indicating that a temporary frozenset is built to support the search.
Mariatta
approved these changes
Jun 1, 2017
rhettinger
approved these changes
Jun 1, 2017
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Jun 1, 2017
(cherry picked from commit 0737ee2)
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Jun 1, 2017
(cherry picked from commit 0737ee2)
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Jun 1, 2017
(cherry picked from commit 0737ee2)
Mariatta
added a commit
that referenced
this pull request
Jun 1, 2017
Mariatta
added a commit
that referenced
this pull request
Jun 1, 2017
Mariatta
added a commit
that referenced
this pull request
Jun 1, 2017
Member
|
Thanks for the PR @JulienPalard 🎉 |
Member
Author
|
Thanks for the merge in all relevant branches @Mariatta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found that this note is refering to code that has been dropped in 51ced7a.