bpo-39320: Don't use an oparg for new DICT_* opcodes.#18243
Closed
brandtbucher wants to merge 4 commits into
Closed
bpo-39320: Don't use an oparg for new DICT_* opcodes.#18243brandtbucher wants to merge 4 commits into
brandtbucher wants to merge 4 commits into
Conversation
Member
|
I'd prefer to keep the new opcodes as they are. There is no efficiency gain in ignoring the |
Member
Author
|
That makes sense; thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The oparg for these new, simpler opcodes is always 1. @markshannon
https://bugs.python.org/issue39320