[3.8] bpo-38634: Allow non-apple build to cope with libedit (GH-16986)#17466
Merged
miss-islington merged 1 commit intoDec 4, 2019
python:3.8python/cpython:3.8from
miss-islington:backport-7105319-3.8miss-islington/cpython:backport-7105319-3.8Copy head branch name to clipboard
Merged
[3.8] bpo-38634: Allow non-apple build to cope with libedit (GH-16986)#17466miss-islington merged 1 commit intopython:3.8python/cpython:3.8from miss-islington:backport-7105319-3.8miss-islington/cpython:backport-7105319-3.8Copy head branch name to clipboard
miss-islington merged 1 commit into
python:3.8python/cpython:3.8from
miss-islington:backport-7105319-3.8miss-islington/cpython:backport-7105319-3.8Copy head branch name to clipboard
Conversation
The readline module now detects if Python is linked to libedit at runtime on all platforms. Previously, the check was only done on macOS. If Python is used as a library by a binary linking to libedit, the linker resolves the rl_initialize symbol required by the readline module against libedit instead of libreadline, which leads to a segfault. Take advantage of the existing supporting code to have readline module being compatible with both situations. (cherry picked from commit 7105319) Co-authored-by: serge-sans-paille <serge.guelton@telecom-bretagne.eu>
Contributor
Author
|
@serge-sans-paille and @vstinner: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@serge-sans-paille and @vstinner: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@serge-sans-paille and @vstinner: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readline module now detects if Python is linked to libedit at runtime
on all platforms. Previously, the check was only done on macOS.
If Python is used as a library by a binary linking to libedit, the linker
resolves the rl_initialize symbol required by the readline module against
libedit instead of libreadline, which leads to a segfault.
Take advantage of the existing supporting code to have readline module being
compatible with both situations.
(cherry picked from commit 7105319)
Co-authored-by: serge-sans-paille serge.guelton@telecom-bretagne.eu
https://bugs.python.org/issue38634