bpo-38803: Fix leak in posixmodule#17373
Merged
benjaminp merged 1 commit intoNov 26, 2019
python:masterpython/cpython:masterfrom
eduardo-elizondo:posix-leak-fixeduardo-elizondo/cpython:posix-leak-fixCopy head branch name to clipboard
Merged
bpo-38803: Fix leak in posixmodule#17373benjaminp merged 1 commit intopython:masterpython/cpython:masterfrom eduardo-elizondo:posix-leak-fixeduardo-elizondo/cpython:posix-leak-fixCopy head branch name to clipboard
benjaminp merged 1 commit into
python:masterpython/cpython:masterfrom
eduardo-elizondo:posix-leak-fixeduardo-elizondo/cpython:posix-leak-fixCopy head branch name to clipboard
Conversation
Contributor
Author
|
cc @vstinner |
corona10
approved these changes
Nov 25, 2019
corona10
left a comment
Member
There was a problem hiding this comment.
@eduardo-elizondo cc @vstinner
Thanks for your contribution.
I checked your PR locally and it works well.
master
Python 3.9.0a1+ (heads/master:27fc3b6, Nov 25 2019, 17:29:57
$ ./python -m test test_wait3 -R 3:3 -j0
0:00:00 load avg: 0.00 Run tests in parallel using 10 child processes
0:00:30 load avg: 0.00 running: test_wait3 (30.0 sec)
0:00:36 load avg: 0.00 [1/1/1] test_wait3 failed (36.6 sec)
beginning 6 repetitions
123456
......
test_wait3 leaked [23, 22, 22] references, sum=67
== Tests result: FAILURE ==
1 test failed:
test_wait3
Total duration: 36.9 sec
Tests result: FAILURE
Proposed
Python 3.9.0a1+ (heads/pr/17373:b67e20e, Nov 25 2019, 17:27:28)
$ ./python -m test test_wait3 -R 3:3 -j0
0:00:00 load avg: 0.00 Run tests in parallel using 10 child processes
0:00:30 load avg: 0.00 running: test_wait3 (30.0 sec)
0:00:36 load avg: 0.00 [1/1] test_wait3 passed (36.6 sec)
beginning 6 repetitions
123456
......
== Tests result: SUCCESS ==
1 test OK.
Total duration: 37.0 sec
Tests result: SUCCESS
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a leak in posixmodule by running my leak detection tool:
This quickly pointed out to the function that pulled out the struct_rusage class.
Run after the fix:
https://bugs.python.org/issue38803