Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gh-69708: IDLE "Save As" warnings#17051

Open
ZackerySpytz wants to merge 1 commit into
python:mainpython/cpython:mainfrom
ZackerySpytz:bpo-25522-idle-save-warningsZackerySpytz/cpython:bpo-25522-idle-save-warningsCopy head branch name to clipboard
Open

gh-69708: IDLE "Save As" warnings#17051
ZackerySpytz wants to merge 1 commit into
python:mainpython/cpython:mainfrom
ZackerySpytz:bpo-25522-idle-save-warningsZackerySpytz/cpython:bpo-25522-idle-save-warningsCopy head branch name to clipboard

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Nov 5, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Give a warning when attempting to save a file that shadows a module
in the standard library.

https://bugs.python.org/issue25522

@ZackerySpytz
bpo-25522: IDLE "Save As" warnings
6cafdc8 
Give a warning when attempting to save a file that shadows a module
in the standard library.
@hauntsaninja hauntsaninja changed the title bpo-25522: IDLE "Save As" warnings gh-69708: IDLE "Save As" warnings Jan 7, 2023
@serhiy-storchaka

serhiy-storchaka commented Dec 26, 2023

Copy link
Copy Markdown
Member
  1. The warning should only be emitted if the file extension matches Python source extensions. IDLE allows to edit other text files, they do not conflict with modules.
  2. The warning should only be emitted for saving a new file. If file already exists, then the user already saved it and asked the question.
  3. There should be more reliable way to determine if the name conflicts with an existing module. For example using importlib.util.find_spec().

@terryjreedy terryjreedy mentioned this pull request Aug 6, 2024
Open
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZackerySpytz @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.