Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-38636: Fix IDLE tab toggle and file indent width#17008

Merged
terryjreedy merged 5 commits into
python:masterpython/cpython:masterfrom
terryjreedy:indentsterryjreedy/cpython:indentsCopy head branch name to clipboard
Nov 20, 2019
Merged

bpo-38636: Fix IDLE tab toggle and file indent width#17008
terryjreedy merged 5 commits into
python:masterpython/cpython:masterfrom
terryjreedy:indentsterryjreedy/cpython:indentsCopy head branch name to clipboard

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Oct 31, 2019

Copy link
Copy Markdown
Member

These format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.

https://bugs.python.org/issue38636

These format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
@terryjreedy

Copy link
Copy Markdown
Member Author

I might eventually fix this a different way, but this is simple enough to apply by hand to existing 3.7.5 and 3.8.0 installations -- add a line and edit or replace the two that follow.

I intend to add new tests before merging.

@taleinat

Copy link
Copy Markdown
Contributor

This is such an obvious fix, I suggest just merging it.

I'm not sure we should be automatically testing that all of our menu options work, anyways.

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terryjreedy

Copy link
Copy Markdown
Member Author

The bug being fixed is a faulty binding, so I would one day like to test them automatically as well as manually (which I forgot here), but another time. I did want to finish the format module tests. Just waiting for CI.

@terryjreedy terryjreedy merged commit b846247 into python:master Nov 20, 2019
@terryjreedy terryjreedy deleted the indents branch November 20, 2019 06:18
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2019
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
(cherry picked from commit b846247)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot

Copy link
Copy Markdown

GH-17274 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2019
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
(cherry picked from commit b846247)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot

Copy link
Copy Markdown

GH-17275 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Nov 20, 2019
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
(cherry picked from commit b846247)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Nov 20, 2019
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
(cherry picked from commit b846247)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
These Format menu functions (default shortcuts Alt-T and Alt-U)
were mistakenly disabled in 3.7.5 and 3.8.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.