Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-38282: Correctly manage the Bluetooth L2CAP socket structure in FreeBSD#16738

Merged
pablogsal merged 1 commit into
python:masterpython/cpython:masterfrom
pablogsal:bpo38282pablogsal/cpython:bpo38282Copy head branch name to clipboard
Oct 13, 2019
Merged

bpo-38282: Correctly manage the Bluetooth L2CAP socket structure in FreeBSD#16738
pablogsal merged 1 commit into
python:masterpython/cpython:masterfrom
pablogsal:bpo38282pablogsal/cpython:bpo38282Copy head branch name to clipboard

Conversation

@pablogsal

@pablogsal pablogsal commented Oct 13, 2019

Copy link
Copy Markdown
Member

@pablogsal

pablogsal commented Oct 13, 2019

Copy link
Copy Markdown
Member Author

Tested on the FreeBSD CURRENT buildbots:

BEFORE:

Python build finished successfully!
The necessary bits to build these optional modules were not found:
_gdbm                 _tkinter              spwd               
To find the necessary bits, look in setup.py in detect_modules() for the module's name.


The following modules found by detect_modules() in setup.py, have been
built by the Makefile instead, as configured by the Setup files:
_abc                  atexit                pwd                
time                                                           


Failed to build these modules:
_socket                                                        

AFTER

Python build finished successfully!
The necessary bits to build these optional modules were not found:
_gdbm                 _tkinter              spwd               
To find the necessary bits, look in setup.py in detect_modules() for the module's name.


The following modules found by detect_modules() in setup.py, have been
built by the Makefile instead, as configured by the Setup files:
_abc                  atexit                pwd                
time                                 

@pablogsal pablogsal requested a review from vstinner October 13, 2019 00:28
@pablogsal

pablogsal commented Oct 13, 2019

Copy link
Copy Markdown
Member Author

I am merging this to fix the FreeBSD buildbots, please @vstinner, review this PR and build upon or add something extra if you see something incorrect/improvable. :)

@pablogsal pablogsal merged commit 27b33fb into python:master Oct 13, 2019
@pablogsal pablogsal deleted the bpo38282 branch October 13, 2019 01:03
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.