Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.8] bpo-36670: regrtest bug fixes (GH-16537)#16538

Merged
miss-islington merged 1 commit into
python:3.8python/cpython:3.8from
miss-islington:backport-2ea71a0-3.8miss-islington/cpython:backport-2ea71a0-3.8Copy head branch name to clipboard
Oct 2, 2019
Merged

[3.8] bpo-36670: regrtest bug fixes (GH-16537)#16538
miss-islington merged 1 commit into
python:3.8python/cpython:3.8from
miss-islington:backport-2ea71a0-3.8miss-islington/cpython:backport-2ea71a0-3.8Copy head branch name to clipboard

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 2, 2019

Copy link
Copy Markdown
Contributor
  • Fix TestWorkerProcess.repr(): start_time is only valid
    if _popen is not None.
  • Fix _kill(): don't set _killed to True if _popen is None.
  • _run_process(): only set _killed to False after calling
    run_test_in_subprocess().
    (cherry picked from commit 2ea71a0)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue36670

* Fix TestWorkerProcess.__repr__(): start_time is only valid
  if _popen is not None.
* Fix _kill(): don't set _killed to True if _popen is None.
* _run_process(): only set _killed to False after calling
  run_test_in_subprocess().
(cherry picked from commit 2ea71a0)

Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit a72de93 into python:3.8 Oct 2, 2019
@miss-islington miss-islington deleted the backport-2ea71a0-3.8 branch October 2, 2019 11:54
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.