Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-38321: Fix _testcapimodule.c warning#16494

Merged
vstinner merged 1 commit into
python:masterpython/cpython:masterfrom
vstinner:fix_testcapi_warnCopy head branch name to clipboard
Sep 30, 2019
Merged

bpo-38321: Fix _testcapimodule.c warning#16494
vstinner merged 1 commit into
python:masterpython/cpython:masterfrom
vstinner:fix_testcapi_warnCopy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Sep 30, 2019

Copy link
Copy Markdown
Member

Fix the following warning:

modules\_testcapimodule.c(6409):
warning C4146: unary minus operator applied to unsigned type,
result still unsigned

https://bugs.python.org/issue38321

Fix the following warning:

    modules\_testcapimodule.c(6409):
    warning C4146: unary minus operator applied to unsigned type,
    result still unsigned

@eduardo-elizondo eduardo-elizondo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Comment thread Modules/_testcapimodule.c
return NULL;
}

buffer = PyUnicode_AsUTF8AndSize(unicode, &utf8_len);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my editor removes trailing spaces. Trailing spaces must die!

@vstinner vstinner merged commit aca8c40 into python:master Sep 30, 2019
@vstinner vstinner deleted the fix_testcapi_warn branch September 30, 2019 19:14
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Fix the following warning:

    modules\_testcapimodule.c(6409):
    warning C4146: unary minus operator applied to unsigned type,
    result still unsigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.