bpo-23667: IDLE: Add trim extension to trim trailing whitespace and blankline on save#1644
Closed
mlouielu wants to merge 1 commit into
python:masterpython/cpython:masterfrom
mlouielu:bpo-23667-trim-extensionmlouielu/cpython:bpo-23667-trim-extensionCopy head branch name to clipboard
Closed
bpo-23667: IDLE: Add trim extension to trim trailing whitespace and blankline on save#1644mlouielu wants to merge 1 commit intopython:masterpython/cpython:masterfrom mlouielu:bpo-23667-trim-extensionmlouielu/cpython:bpo-23667-trim-extensionCopy head branch name to clipboard
mlouielu wants to merge 1 commit into
python:masterpython/cpython:masterfrom
mlouielu:bpo-23667-trim-extensionmlouielu/cpython:bpo-23667-trim-extensionCopy head branch name to clipboard
Conversation
|
@mlouielu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @terryjreedy and @loewis to be potential reviewers. |
auvipy
approved these changes
May 31, 2019
Member
|
I am closing this because IDLE already has a function to strip trailing whitespace. It just needs a minor addition to strip trailing blank lines. Also, features are no longer added as extensions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.