bpo-38205: Py_UNREACHABLE() calls Py_FatalError()#16290
Merged
vstinner merged 1 commit intoSep 20, 2019
Merged
Conversation
Member
Author
|
Example from: With RANDALL_WAS_HERE macro defined: |
Member
Author
zware
approved these changes
Sep 19, 2019
Member
Author
|
I will wait for @serhiy-storchaka approval, since he was the one to disagree with my first attempt: |
serhiy-storchaka
approved these changes
Sep 19, 2019
Member
|
Thank you. |
gpshead
approved these changes
Sep 20, 2019
|
The assembly code generated by this PR will push the string OFFSET at the call sites, the assembly code will longer a bit. |
Member
Author
|
"The assembly code generated by this PR will push the string OFFSET at the call sites, the assembly code will longer a bit. If you care about this, you can use a macro points to a non-inline function." I don't care about emitted machine code :-) |
vstinner
added a commit
that referenced
this pull request
Sep 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38205