bpo-38150 Fix refleak in the finalizer of a _testcapimodule type#16115
Merged
miss-islington merged 1 commit intoSep 13, 2019
python:masterpython/cpython:masterfrom
eduardo-elizondo:fix-capi-leakseduardo-elizondo/cpython:fix-capi-leaksCopy head branch name to clipboard
Merged
bpo-38150 Fix refleak in the finalizer of a _testcapimodule type#16115miss-islington merged 1 commit intopython:masterpython/cpython:masterfrom eduardo-elizondo:fix-capi-leakseduardo-elizondo/cpython:fix-capi-leaksCopy head branch name to clipboard
miss-islington merged 1 commit into
python:masterpython/cpython:masterfrom
eduardo-elizondo:fix-capi-leakseduardo-elizondo/cpython:fix-capi-leaksCopy head branch name to clipboard
Conversation
Contributor
Author
|
Since the build bots don't run the test leaks, here's a local repro that is now working: |
Member
|
@eduardo-elizondo yep, I am waiting for the green lanterns from Travis and I will merge your PR. need to test on my laptop but it is already working on your PR ;-) |
Member
|
works fine on my laptop, need to wait for Travis |
matrixise
approved these changes
Sep 13, 2019
Contributor
|
@eduardo-elizondo: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @eduardo-elizondo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Sorry @eduardo-elizondo, I had trouble checking out the |
matrixise
pushed a commit
to matrixise/cpython
that referenced
this pull request
Sep 13, 2019
pythonGH-16115) The PyLong created in the finalizer was not being cleaned up https://bugs.python.org/issue38150 Automerge-Triggered-By: @matrixise (cherry picked from commit a67ac2f) Co-authored-by: Eddie Elizondo <eelizondo@fb.com>
|
GH-16118 is a backport of this pull request to the 3.8 branch. |
matrixise
added a commit
that referenced
this pull request
Sep 13, 2019
…pe (GH-16115) (GH-16118) The PyLong created in the finalizer was not being cleaned up https://bugs.python.org/issue38150 Automerge-Triggered-By: @matrixise (cherry picked from commit a67ac2f) Co-authored-by: Eddie Elizondo <eelizondo@fb.com>
Contributor
Author
|
@matrixise Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PyLong created in the finalizer was not being cleaned up
https://bugs.python.org/issue38150
Automerge-Triggered-By: @matrixise