bpo-37251: Removes __code__ check from _is_async_obj.#15830
Merged
Merged
bpo-37251: Removes __code__ check from _is_async_obj.#15830
Conversation
tirkarthi
reviewed
Sep 10, 2019
Co-Authored-By: Xtreak <tir.karthi@gmail.com>
Contributor
|
Added backport label |
Contributor
|
Thanks @lisroach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 10, 2019
(cherry picked from commit f1a297a) Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
|
GH-15837 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 10, 2019
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be possible that an awaitable object does not have a
__code__, so technically checking for the__code__attribute in_is_async_objis incorrect. This faulty code check is also why things like:mock.MagicMock(spec=lambda x: x)evaluate to True, even though they are not asynchronous.https://bugs.python.org/issue37251