bpo-38031: Fix a possible assertion failure in _io.FileIO()#15688
Merged
iritkatriel merged 12 commits intoNov 25, 2022
python:mainpython/cpython:mainfrom
ZackerySpytz:bpo-38031-_io-FileIO-opener-crashZackerySpytz/cpython:bpo-38031-_io-FileIO-opener-crashCopy head branch name to clipboard
Merged
bpo-38031: Fix a possible assertion failure in _io.FileIO()#15688iritkatriel merged 12 commits intopython:mainpython/cpython:mainfrom ZackerySpytz:bpo-38031-_io-FileIO-opener-crashZackerySpytz/cpython:bpo-38031-_io-FileIO-opener-crashCopy head branch name to clipboard
iritkatriel merged 12 commits into
python:mainpython/cpython:mainfrom
ZackerySpytz:bpo-38031-_io-FileIO-opener-crashZackerySpytz/cpython:bpo-38031-_io-FileIO-opener-crashCopy head branch name to clipboard
Conversation
Use PyErr_Fetch() / _PyErr_ChainExceptions() when calling internal_close() on error. The opener may return an invalid fd, which will cause the close() call in internal_close() to fail.
aeros
reviewed
Sep 5, 2019
Contributor
There was a problem hiding this comment.
Thanks for the PR @ZackerySpytz.
The macOS failures in Azure may be related to https://bugs.python.org/issue37245 and not related to this PR. (Build log: https://dev.azure.com/Python/cpython/_build/results?buildId=49868&view=logs&j=18d1a34d-6940-5fc1-f55b-405e2fba32b1)
2 tests failed: test_functools test_multiprocessing_spawn
Both of the above tests timed out.
vstinner
reviewed
Sep 6, 2019
Member
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Mostly LGTH. Just address Victor's comment.
Contributor
|
@ZackerySpytz, please address the code review. Thanks! |
iritkatriel
reviewed
Nov 23, 2022
iritkatriel
left a comment
Member
There was a problem hiding this comment.
Converted @vstinner's comment into suggestions.
iritkatriel
reviewed
Nov 23, 2022
iritkatriel
reviewed
Nov 23, 2022
iritkatriel
reviewed
Nov 23, 2022
vstinner
reviewed
Nov 24, 2022
iritkatriel
reviewed
Nov 24, 2022
iritkatriel
reviewed
Nov 24, 2022
vstinner
approved these changes
Nov 24, 2022
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for updating the PR @iritkatriel ;-)
iritkatriel
reviewed
Nov 24, 2022
Contributor
|
Thanks @ZackerySpytz for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
This was referenced Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use PyErr_Fetch() / _PyErr_ChainExceptions() when calling
internal_close() on error. The opener may return an invalid
fd, which will cause the close() call in internal_close() to fail.
https://bugs.python.org/issue38031