Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-37849: IDLE: fix completion window positioning above line#15267

Merged
terryjreedy merged 4 commits into
python:masterpython/cpython:masterfrom
taleinat:bpo-37849/idle-completion-window-positiontaleinat/cpython:bpo-37849/idle-completion-window-positionCopy head branch name to clipboard
Aug 14, 2019
Merged

bpo-37849: IDLE: fix completion window positioning above line#15267
terryjreedy merged 4 commits into
python:masterpython/cpython:masterfrom
taleinat:bpo-37849/idle-completion-window-positiontaleinat/cpython:bpo-37849/idle-completion-window-positionCopy head branch name to clipboard

Conversation

@taleinat

@taleinat taleinat commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

This also adds a mechanism to avoid multiple, recursive invocations of the "<Configure>" event handler, required due to the added .update() call.

https://bugs.python.org/issue37849

Added a mechanism to avoid multiple, recursive invocations of the
"<Configure>" event handler, required due to the added .update() call.
@terryjreedy

Copy link
Copy Markdown
Member

New news items go on top, with the fixed length divider line and 2 blank lines above and a blank line and the previous item below. As long as all are backported, all will backport without conflict in either the upper or lower 3-line context. In this case, there was a previous item to be added also.

For the first news addition after a final release, which requires a new header at least on that version, the lower context will be different on different versions. So I do the addition on separate PRs (master and manual backports as needed) attached to the current next-version NEWS issue (now bpo 34162 for 3.8). I also use that for corrections and batch additions.

@terryjreedy terryjreedy merged commit 71662dc into python:master Aug 14, 2019
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019
…GH-15267)

(cherry picked from commit 71662dc)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-15282 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-15283 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019
…GH-15267)

(cherry picked from commit 71662dc)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Aug 14, 2019
(cherry picked from commit 71662dc)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Aug 14, 2019
(cherry picked from commit 71662dc)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.