bpo-12611: 2to3 crashes when converting doctest using reduce()#15249
Closed
aldwinaldwin wants to merge 4 commits into
python:mainpython/cpython:mainfrom
aldwinaldwin:2to3doctestreducealdwinaldwin/cpython:2to3doctestreduceCopy head branch name to clipboard
Closed
bpo-12611: 2to3 crashes when converting doctest using reduce()#15249aldwinaldwin wants to merge 4 commits intopython:mainpython/cpython:mainfrom aldwinaldwin:2to3doctestreducealdwinaldwin/cpython:2to3doctestreduceCopy head branch name to clipboard
aldwinaldwin wants to merge 4 commits into
python:mainpython/cpython:mainfrom
aldwinaldwin:2to3doctestreducealdwinaldwin/cpython:2to3doctestreduceCopy head branch name to clipboard
Conversation
corona10
reviewed
Aug 26, 2019
| new = str(tree).splitlines(keepends=True) | ||
| # Adjust lineno for lines inserted before | ||
| jmp = 0 | ||
| for n in new: |
Member
There was a problem hiding this comment.
IMHO
This logic can be replaced by
jmp = max(new.index('\n'), 0)
epicfaace
reviewed
Aug 27, 2019
| @@ -0,0 +1 @@ | ||
| 2to3 converting doctest using reduce(). Patch by Aldwin Pollefeyt. |
Contributor
There was a problem hiding this comment.
Suggested change
| 2to3 converting doctest using reduce(). Patch by Aldwin Pollefeyt. | |
| Fix 2to3 crashing when run on a doctest that uses reduce(). Patch by Aldwin Pollefeyt. |
Member
|
Closed under bpo-45544. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue12611