Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix incomplete sentence in tp_itemsize documentation - #152381

#152381
Merged
ZeroIntensity merged 1 commit into
python:mainpython/cpython:mainfrom
da-woods:patch-3da-woods/cpython:patch-3Copy head branch name to clipboard
Jun 27, 2026
Merged

Fix incomplete sentence in tp_itemsize documentation#152381
ZeroIntensity merged 1 commit into
python:mainpython/cpython:mainfrom
da-woods:patch-3da-woods/cpython:patch-3Copy head branch name to clipboard

Conversation

@da-woods

@da-woods da-woods commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@da-woods
da-woods requested a review from ZeroIntensity as a code owner June 27, 2026 10:06
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Jun 27, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jun 27, 2026
@read-the-docs-community

read-the-docs-community Bot commented Jun 27, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33335616 | 📁 Comparing d79fb8d against main (93454fe)

  🔍 Preview build  

1 file changed
± c-api/type.html

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 27, 2026
@ZeroIntensity
ZeroIntensity merged commit 0a21a24 into python:main Jun 27, 2026
50 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 27, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 27, 2026

Copy link
Copy Markdown

Thanks @da-woods for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 27, 2026

Copy link
Copy Markdown

Sorry, @da-woods and @ZeroIntensity, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0a21a248cc97eba3d75c7bd07c849ec645aea87b 3.14

@bedevere-app

bedevere-app Bot commented Jun 27, 2026

Copy link
Copy Markdown

GH-152417 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 27, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 27, 2026

Copy link
Copy Markdown

Sorry, @da-woods and @ZeroIntensity, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0a21a248cc97eba3d75c7bd07c849ec645aea87b 3.13

@ZeroIntensity

ZeroIntensity commented Jun 27, 2026

Copy link
Copy Markdown
Member

Ah, Py_tp_itemsize was only added in 3.15.

@ZeroIntensity ZeroIntensity removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 27, 2026
@da-woods

da-woods commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

I think the sentence does exist in 3.13 does just under a slightly different heading https://docs.python.org/3.13/c-api/type.html#c.PyType_Spec.itemsize

@ZeroIntensity

ZeroIntensity commented Jun 27, 2026

Copy link
Copy Markdown
Member

Okay, good catch. Do you want to handle the backports?

@da-woods

da-woods commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

Yeah I can do (within the next hour or so... distracted by something else right now)

ZeroIntensity pushed a commit that referenced this pull request Jun 27, 2026
@miss-islington @da-woods
[3.15] Docs: Fix incomplete sentence in tp_itemsize documentation (G…
400c7ec 
…H-152381) (GH-152417)

(cherry picked from commit 0a21a24)

Co-authored-by: da-woods <dw-git@d-woods.co.uk>
@bedevere-app

bedevere-app Bot commented Jun 27, 2026

Copy link
Copy Markdown

GH-152423 is a backport of this pull request to the 3.13 branch.

@bedevere-app

bedevere-app Bot commented Jun 27, 2026

Copy link
Copy Markdown

GH-152424 is a backport of this pull request to the 3.14 branch.

@da-woods
da-woods deleted the patch-3 branch June 27, 2026 15:07
encukou pushed a commit that referenced this pull request Jul 1, 2026
@da-woods
[3.14] Docs: Fix incomplete sentence in tp_itemsize documentation (G…
b14ea66 
…H-152381) (GH-152424)

(cherry picked from commit 0a21a24)
encukou pushed a commit that referenced this pull request Jul 1, 2026
@da-woods
[3.13] Docs: Fix incomplete sentence in tp_itemsize documentation (G…
bb7fb4d 
…H-152381) (GH-152423)

(cherry picked from commit 0a21a24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees

@ZeroIntensity ZeroIntensity

Labels

docs Documentation in the Doc dir skip issue skip news topic-C-API

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@da-woods @ZeroIntensity @StanFromIreland
Morty Proxy This is a proxified and sanitized view of the page, visit original site.