Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[2.7] bpo-29243: Fix Makefile with respect to --enable-optimizations …#1522

Merged
vstinner merged 1 commit into
python:2.7python/cpython:2.7from
torsava:backport-a1054c3-2.7torsava/cpython:backport-a1054c3-2.7Copy head branch name to clipboard
May 9, 2017
Merged

[2.7] bpo-29243: Fix Makefile with respect to --enable-optimizations …#1522
vstinner merged 1 commit into
python:2.7python/cpython:2.7from
torsava:backport-a1054c3-2.7torsava/cpython:backport-a1054c3-2.7Copy head branch name to clipboard

Conversation

@torsava

@torsava torsava commented May 9, 2017

Copy link
Copy Markdown
Contributor

…(GH-1478)

  • bpo-29243: Fix Makefile with respect to --enable-optimizations

When using the Profile Guided Optimization (./configure --enable-optimizations)
Python is built not only during make but rebuilt again during make test,
make install and others. This patch fixes the issue.

Note that this fix produces no change at all in the Makefile if configure is
run witout --enable-optimizations.

  • !squash.
    (cherry picked from commit a1054c3)

…ythonGH-1478)

* bpo-29243: Fix Makefile with respect to --enable-optimizations

When using the Profile Guided Optimization (./configure --enable-optimizations)
Python is built not only during `make` but rebuilt again during `make test`,
`make install` and others. This patch fixes the issue.

Note that this fix produces no change at all in the Makefile if configure is
run witout --enable-optimizations.

* !squash.
(cherry picked from commit a1054c3)
@torsava

torsava commented May 9, 2017

Copy link
Copy Markdown
Contributor Author

Differences with the 3.x branch:

  • memtest: also got @DEF_MAKE_RULE@ instead of all
  • patchcheck: does not have all in the prerequisites, so it was net changed

@vstinner vstinner merged commit a473a73 into python:2.7 May 9, 2017
@vstinner

vstinner commented May 9, 2017

Copy link
Copy Markdown
Member

Thank you! It seems like the bug is now fixed in all maintained branches!

@torsava

torsava commented May 9, 2017

Copy link
Copy Markdown
Contributor Author

I believe so. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.