Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-25172: Raise appropriate ImportError msg when crypt module used on Windows#15149

Merged
pfmoore merged 6 commits into
python:masterpython/cpython:masterfrom
shireenrao:cryptfixshireenrao/cpython:cryptfixCopy head branch name to clipboard
Aug 8, 2019
Merged

bpo-25172: Raise appropriate ImportError msg when crypt module used on Windows#15149
pfmoore merged 6 commits into
python:masterpython/cpython:masterfrom
shireenrao:cryptfixshireenrao/cpython:cryptfixCopy head branch name to clipboard

Conversation

@shireenrao

@shireenrao shireenrao commented Aug 6, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

the-knights-who-say-ni commented Aug 6, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

pfmoore
pfmoore reviewed Aug 6, 2019
View reviewed changes
Comment thread Misc/NEWS.d/next/Windows/2019-08-06-18-09-18.bpo-25172.Akreij.rst Outdated
zooba
zooba reviewed Aug 6, 2019
View reviewed changes
Comment thread Misc/NEWS.d/next/Windows/2019-08-06-18-09-18.bpo-25172.Akreij.rst Outdated
@zooba

zooba commented Aug 6, 2019

Copy link
Copy Markdown
Member

This looks good to me. Once the CLA is cleared it can be merged (the tag will update automatically).

@shireenrao @zooba
Update Misc/NEWS.d/next/Windows/2019-08-06-18-09-18.bpo-25172.Akreij.rst
808cf39 
Co-Authored-By: Steve Dower <steve.dower@microsoft.com>
@pfmoore pfmoore merged commit f4e725f into python:master Aug 8, 2019
@miss-islington

miss-islington commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

Thanks @shireenrao for the PR, and @pfmoore for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2019
@shireenrao @miss-islington
bpo-25172: Raise appropriate ImportError msg when crypt module used o…
6a3c052 
…n Windows (pythonGH-15149)

(cherry picked from commit f4e725f)

Co-authored-by: shireenrao <shireenrao@gmail.com>
@bedevere-bot

bedevere-bot commented Aug 8, 2019

Copy link
Copy Markdown

GH-15182 is a backport of this pull request to the 3.8 branch.

@pfmoore

pfmoore commented Aug 8, 2019

Copy link
Copy Markdown
Member

Thanks for the contribution, @shireenrao!

@shireenrao

shireenrao commented Aug 8, 2019

Copy link
Copy Markdown
Contributor Author

Thank you @pfmoore @zooba and @mangrisano for accepting my first PR 🙏

@shireenrao shireenrao deleted the cryptfix branch August 8, 2019 20:05
@pfmoore

pfmoore commented Aug 13, 2019

Copy link
Copy Markdown
Member

@zooba you added the needs-backport label here. The backport PR is awaiting merge, does it need manually merging? I'm not super familiar with what miss-islington does with backports, and what still needs to be handled manually.

Also, I assume the follow-up PR with a test should be backported too?

miss-islington added a commit that referenced this pull request Aug 13, 2019
@miss-islington @shireenrao
bpo-25172: Raise appropriate ImportError msg when crypt module used o…
7f7f747 
…n Windows (GH-15149)

(cherry picked from commit f4e725f)

Co-authored-by: shireenrao <shireenrao@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@shireenrao @lisroach
bpo-25172: Raise appropriate ImportError msg when crypt module used o…
daec426 
…n Windows (pythonGH-15149)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@shireenrao @DinoV
bpo-25172: Raise appropriate ImportError msg when crypt module used o…
963588a 
…n Windows (pythonGH-15149)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@shireenrao @websurfer5
bpo-25172: Raise appropriate ImportError msg when crypt module used o…
f9a6862 
…n Windows (pythonGH-15149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

@pfmoore pfmoore pfmoore approved these changes

+1 more reviewer

@mangrisano mangrisano mangrisano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shireenrao @the-knights-who-say-ni @zooba @miss-islington @bedevere-bot @pfmoore @mangrisano
Morty Proxy This is a proxified and sanitized view of the page, visit original site.