gh-151039: Fix a crash when datetime.timedelta outlives _datetime module#151044
Open
sobolevn wants to merge 4 commits into
Open
gh-151039: Fix a crash when datetime.timedelta outlives _datetime module#151044sobolevn wants to merge 4 commits into
datetime.timedelta outlives _datetime module#151044sobolevn wants to merge 4 commits into
Conversation
Member
Author
|
Ok, I just discovered #132413 which is related. |
…Z0qBn.rst Co-authored-by: Stan Ulbrych <stan@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several changes:
GET_CURRENT_STATEcan returnNULL(void)PyWeakref_GetRefcall into a full check for safety, there are multiple things that can go wrong when getting a weakrefassert(!PyErr_Occurred());followed byif (PyErr_Occurred()) {