gh-151022: Fix remote debugging linetable reads#151036
Open
goutamadwant wants to merge 1 commit into
python:mainpython/cpython:mainfrom
goutamadwant:gh-151022-remote-debugging-linetablegoutamadwant/cpython:gh-151022-remote-debugging-linetableCopy head branch name to clipboard
Open
gh-151022: Fix remote debugging linetable reads#151036goutamadwant wants to merge 1 commit intopython:mainpython/cpython:mainfrom goutamadwant:gh-151022-remote-debugging-linetablegoutamadwant/cpython:gh-151022-remote-debugging-linetableCopy head branch name to clipboard
goutamadwant wants to merge 1 commit into
python:mainpython/cpython:mainfrom
goutamadwant:gh-151022-remote-debugging-linetablegoutamadwant/cpython:gh-151022-remote-debugging-linetableCopy head branch name to clipboard
Conversation
|
All commit authors signed the Contributor License Agreement. |
34645da to
9b0f3ba
Compare
Member
|
@maurycy can you review this? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-151022.
_remote_debugging reads a code object's line table from the target process
with a fixed 4096 byte limit. Valid code objects can exceed that. For example,
Lib/html/entities.py currently compiles to a line table of 37445 bytes, so
RemoteUnwinder.get_stack_trace() fails with RuntimeError: Invalid bytes length.
This keeps the generic remote bytes reader bounded, but gives code object line
tables their own larger limit before parsing. The parser already bounds the
number of line table entries it will scan.
Added a regression test that builds a code object with a line table larger than
4096 bytes and verifies that a same-process stack trace succeeds.
Tests:
./python.exe -m unittest -v test.test_external_inspection.TestSelfStackTrace.test_self_trace_with_large_linetable
./python.exe -m test test_external_inspection -v
make patchcheck