python · miss-islington · Jul 30, 2019 · Jul 30, 2019 · Jul 30, 2019 · Jul 30, 2019
diff --git a/Doc/library/parser.rst b/Doc/library/parser.rst
@@ -25,11 +25,11 @@ from this.  This is better than trying to parse and modify an arbitrary Python
 code fragment as a string because parsing is performed in a manner identical to
 the code forming the application.  It is also faster.

-.. note::
+.. warning::

-   From Python 2.5 onward, it's much more convenient to cut in at the Abstract
-   Syntax Tree (AST) generation and compilation stage, using the :mod:`ast`
-   module.
+   The parser module is deprecated and will be removed in future versions of
+   Python. For the majority of use cases you can leverage the Abstract Syntax
+   Tree (AST) generation and compilation stage, using the :mod:`ast` module.

 There are a few things to note about this module which are important to making
 use of the data structures created.  This is not a tutorial on editing the parse

diff --git a/Doc/whatsnew/3.9.rst b/Doc/whatsnew/3.9.rst
@@ -142,6 +142,10 @@ Deprecated
  Python versions it will raise a :exc:`TypeError` for all floats.
  (Contributed by Serhiy Storchaka in :issue:`37315`.)

+* The :mod:`parser` module is deprecated and will be removed in future versions
+  of Python. For the majority of use cases users can leverage the Abstract Syntax
+  Tree (AST) generation and compilation stage, using the :mod:`ast` module.
+

 Removed
 =======

diff --git a/Lib/test/test_parser.py b/Lib/test/test_parser.py
@@ -6,6 +6,7 @@
 import struct
 from test import support
 from test.support.script_helper import assert_python_failure
+from test.support.script_helper import assert_python_ok

 #
 #  First, we test that we can generate trees from valid source fragments,
@@ -987,5 +988,13 @@ def test_two_args_to_expr(self):
        with self.assertRaises(TypeError):
            parser.expr("a", "b")

+
+class TestDeprecation(unittest.TestCase):
+    def test_deprecation_message(self):
+        code = "def f():\n  import parser\n\nf()"
+        rc, out, err = assert_python_ok('-c', code)
+        self.assertIn(b'<string>:2: DeprecationWarning', err)
+
+
 if __name__ == "__main__":
    unittest.main()
diff --git a/Misc/NEWS.d/next/Library/2019-07-30-01-27-29.bpo-37268.QDmA44.rst b/Misc/NEWS.d/next/Library/2019-07-30-01-27-29.bpo-37268.QDmA44.rst
@@ -0,0 +1,2 @@
+The :mod:`parser` module is deprecated and will be removed in future
+versions of Python.
diff --git a/Modules/parsermodule.c b/Modules/parsermodule.c
@@ -1158,6 +1158,12 @@ PyInit_parser(void)
 {
    PyObject *module, *copyreg;

+    if (PyErr_WarnEx(PyExc_DeprecationWarning,
+            "The parser module is deprecated and will be removed "
+            "in future versions of Python", 7) != 0) {
+        return NULL;
+    }
+
    if (PyType_Ready(&PyST_Type) < 0)
        return NULL;
    module = PyModule_Create(&parsermodule);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		The :mod:`parser` module is deprecated and will be removed in future
		versions of Python.
-Original file line number
+Diff line change
@@ -1158,6 +1158,12 @@ PyInit_parser(void)
     {
         PyObject *module, *copyreg;
+        if (PyErr_WarnEx(PyExc_DeprecationWarning,
+                "The parser module is deprecated and will be removed "
+                "in future versions of Python", 7) != 0) {
         Comment thread


        

        
      

        
          


  
    
        
        
  
    
      
          
      

      
            pablogsal
  

      

      

      


        Jul 30, 2019



      
  •

  
    
      
        
          edited
          
        
        
      
    
    
      
  
        
      Loading


  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  
    
  


    

  

  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        

  
  Member


        

  Author


    
  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      7 is the magic number to skip all importlib._bootstrap_external (tested in test_deprecation_message). 🙃
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
+            return NULL;
+        }
         if (PyType_Ready(&PyST_Type) < 0)
             return NULL;
         module = PyModule_Create(&parsermodule);
-          Expand Down