gh-145306: Fix browser open after empty export#150017
Open
ivonastojanovic wants to merge 2 commits into
python:mainpython/cpython:mainfrom
lkollar:tachyon/fix-browser-openlkollar/cpython:tachyon/fix-browser-openCopy head branch name to clipboard
Open
gh-145306: Fix browser open after empty export#150017ivonastojanovic wants to merge 2 commits intopython:mainpython/cpython:mainfrom lkollar:tachyon/fix-browser-openlkollar/cpython:tachyon/fix-browser-openCopy head branch name to clipboard
ivonastojanovic wants to merge 2 commits into
python:mainpython/cpython:mainfrom
lkollar:tachyon/fix-browser-openlkollar/cpython:tachyon/fix-browser-openCopy head branch name to clipboard
Conversation
maurycy
reviewed
May 19, 2026
| if args.format in ('flamegraph', 'diff_flamegraph', 'heatmap') and getattr(args, 'browser', False): | ||
| if ( | ||
| export_ok | ||
| and args.format in ('flamegraph', 'diff_flamegraph', 'heatmap') |
Contributor
There was a problem hiding this comment.
What do you think about reducing duplication here and in
and, maybe:
Contributor
Author
There was a problem hiding this comment.
Sounds good, I think introducing BROWSER_COMPATIBLE_FORMATS makes sense here. @lkollar could you make that change?
Make sampling exporters report whether output was generated, and only open HTML reports in the browser after a successful export.
e98a58b to
4334b0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sampling exporters report whether output was generated, and only open HTML reports in the browser after a successful export.