bpo-37685: Fixed comparisons of datetime.timedelta and datetime.timezone.#14996
Merged
serhiy-storchaka merged 4 commits intoAug 4, 2019
python:masterpython/cpython:masterfrom
serhiy-storchaka:datetime-comparisonsserhiy-storchaka/cpython:datetime-comparisonsCopy head branch name to clipboard
Merged
bpo-37685: Fixed comparisons of datetime.timedelta and datetime.timezone.#14996serhiy-storchaka merged 4 commits intopython:masterpython/cpython:masterfrom serhiy-storchaka:datetime-comparisonsserhiy-storchaka/cpython:datetime-comparisonsCopy head branch name to clipboard
serhiy-storchaka merged 4 commits into
python:masterpython/cpython:masterfrom
serhiy-storchaka:datetime-comparisonsserhiy-storchaka/cpython:datetime-comparisonsCopy head branch name to clipboard
Conversation
…one. There was a discrepancy between the Python and C implementations.
4720287 to
1abb9cf
Compare
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 4, 2019
…one. (pythonGH-14996) There was a discrepancy between the Python and C implementations. Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support to test mixed type comparison. (cherry picked from commit 17e5264) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-15102 is a backport of this pull request to the 3.8 branch. |
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
Contributor
|
Sorry @serhiy-storchaka, I had trouble checking out the |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Aug 4, 2019
….timezone. (pythonGH-14996) There was a discrepancy between the Python and C implementations. Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support to test mixed type comparison.. (cherry picked from commit 17e5264) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-15104 is a backport of this pull request to the 3.7 branch. |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…one. (pythonGH-14996) There was a discrepancy between the Python and C implementations. Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support to test mixed type comparison.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…one. (pythonGH-14996) There was a discrepancy between the Python and C implementations. Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support to test mixed type comparison.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…one. (pythonGH-14996) There was a discrepancy between the Python and C implementations. Add singletons ALWAYS_EQ, LARGEST and SMALLEST in test.support to test mixed type comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a discrepancy between the Python and C implementations.
This is a part of #14952 which should be backported.
https://bugs.python.org/issue37685