gh-149225: Expose Py_CriticalSection in Stable ABI#149227
Merged
encukou merged 7 commits intoMay 4, 2026
python:mainpython/cpython:mainfrom
encukou:critical-section-stable-abi-xsencukou/cpython:critical-section-stable-abi-xsCopy head branch name to clipboard
Merged
gh-149225: Expose Py_CriticalSection in Stable ABI#149227encukou merged 7 commits intopython:mainpython/cpython:mainfrom encukou:critical-section-stable-abi-xsencukou/cpython:critical-section-stable-abi-xsCopy head branch name to clipboard
encukou merged 7 commits into
python:mainpython/cpython:mainfrom
encukou:critical-section-stable-abi-xsencukou/cpython:critical-section-stable-abi-xsCopy head branch name to clipboard
Conversation
Documentation build overview
43 files changed ·
|
corona10
reviewed
May 1, 2026
vstinner
approved these changes
May 2, 2026
| // Operations that need to lock two objects at once must use | ||
| // `Py_BEGIN_CRITICAL_SECTION2()`. You *CANNOT* use nested critical sections | ||
| // to lock more than one object at once, because the inner critical section | ||
| // may suspend the outer critical sections. This API does not provide a way |
Member
There was a problem hiding this comment.
Suggested change
| // may suspend the outer critical sections. This API does not provide a way | |
| // may suspend the outer critical sections. This API does not provide a way |
| @@ -0,0 +1,2 @@ | ||
| :c:type:`PyCriticalSection` and related functions are added to the Stable | ||
| ABI. |
Member
There was a problem hiding this comment.
Can you copy also this paragraph to What's New in Python 3.15 > C API changes > New features?
Member
Oh, the "FAIL: test_got_eof (test.test_ssl.ThreadedTests.test_got_eof)" failure is related to my recent OpenSSL 4 changes. I wrote #149366 to fix the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.