Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.13] gh-141473: Speed up subprocess test_communicate_timeout_large_input long tail (GH-149003)#149005

Merged
gpshead merged 1 commit into
python:3.13python/cpython:3.13from
miss-islington:backport-e1384cf-3.13miss-islington/cpython:backport-e1384cf-3.13Copy head branch name to clipboard
Apr 26, 2026
Merged

[3.13] gh-141473: Speed up subprocess test_communicate_timeout_large_input long tail (GH-149003)#149005
gpshead merged 1 commit into
python:3.13python/cpython:3.13from
miss-islington:backport-e1384cf-3.13miss-islington/cpython:backport-e1384cf-3.13Copy head branch name to clipboard

Conversation

@miss-islington

Copy link
Copy Markdown
Contributor

gh-141473: Speed up test_communicate_timeout_large_input

Replace the slow reader's 30s sleep with a parent-driven wake over a
loopback socket so post-timeout communicate() doesn't block waiting
for the child to wake on its own. Worst-case runtime: ~30s -> <1s.
(cherry picked from commit e1384cf)

Co-authored-by: Gregory P. Smith 68491+gpshead@users.noreply.github.com

…nput long tail (pythonGH-149003)

pythongh-141473: Speed up test_communicate_timeout_large_input

Replace the slow reader's 30s sleep with a parent-driven wake over a
loopback socket so post-timeout communicate() doesn't block waiting
for the child to wake on its own. Worst-case runtime: ~30s -> <1s.
(cherry picked from commit e1384cf)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
@miss-islington miss-islington requested a review from gpshead as a code owner April 26, 2026 04:01
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 26, 2026
@gpshead gpshead enabled auto-merge (squash) April 26, 2026 04:06
@gpshead gpshead merged commit 898ecdd into python:3.13 Apr 26, 2026
42 of 43 checks passed
@miss-islington miss-islington deleted the backport-e1384cf-3.13 branch April 26, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.