Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

gh-148832: Use -icf=0 in BOLT_APPLY_FLAGS#148833

Merged
corona10 merged 7 commits into
python:mainpython/cpython:mainfrom
ashm-dev:bolt-icf-safeashm-dev/cpython:bolt-icf-safeCopy head branch name to clipboard
Jun 6, 2026
Merged

gh-148832: Use -icf=0 in BOLT_APPLY_FLAGS#148833
corona10 merged 7 commits into
python:mainpython/cpython:mainfrom
ashm-dev:bolt-icf-safeashm-dev/cpython:bolt-icf-safeCopy head branch name to clipboard

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

@ashm-dev ashm-dev changed the title gh-148832: Use -icf=safe in BOLT_APPLY_FLAGS gh-148832: Use -icf=0 in BOLT_APPLY_FLAGS Apr 21, 2026
@corona10 corona10 self-assigned this Apr 22, 2026
@ashm-dev

Copy link
Copy Markdown
Contributor Author

@corona10 @erlend-aasland could you please review this PR?

@ashm-dev

Copy link
Copy Markdown
Contributor Author

Gentle ping — this is a small, low-risk build-flag change (-icf=0 in BOLT_APPLY_FLAGS) that's been awaiting review for ~4 weeks. @AA-Turner @emmatyping you were both auto-requested as reviewers — would either of you have a moment to take a look?

@corona10 corona10 requested a review from itamaro as a code owner June 6, 2026 06:41

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@corona10 corona10 enabled auto-merge (squash) June 6, 2026 06:41
@corona10 corona10 merged commit 2452449 into python:main Jun 6, 2026
134 of 138 checks passed
@ashm-dev ashm-dev deleted the bolt-icf-safe branch June 6, 2026 08:49
philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.