gh-148675: Revert GH-146237 and GH-146241#148674
Closed
skirpichev wants to merge 3 commits into
python:mainpython/cpython:mainfrom
skirpichev:revert-146237and146241skirpichev/cpython:revert-146237and146241Copy head branch name to clipboard
Closed
gh-148675: Revert GH-146237 and GH-146241#148674skirpichev wants to merge 3 commits intopython:mainpython/cpython:mainfrom skirpichev:revert-146237and146241skirpichev/cpython:revert-146237and146241Copy head branch name to clipboard
skirpichev wants to merge 3 commits into
python:mainpython/cpython:mainfrom
skirpichev:revert-146237and146241skirpichev/cpython:revert-146237and146241Copy head branch name to clipboard
Conversation
…module (python#146237)" This reverts commit 0e3b3b8.
… (complex) (python#146241)" This reverts commit c68a194.
Member
Member
Author
Shouldn't this be approved by some other core developer? |
Member
|
Usually, yes, I prefer to wait for an approval of another core dev. In this case, I rushed to merge the PR to make sure that it lands into Python 3.15 alpha1. I don't like working under pressure like that. I hope that we will time to digest these changes and cleanup the code and the doc before Python 3.15 final. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--148674.org.readthedocs.build/
ZfandZd#148675